Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getJpegInfo to skip DHT marker #3667

Closed
wants to merge 2 commits into from
Closed

fix getJpegInfo to skip DHT marker #3667

wants to merge 2 commits into from

Conversation

rnigro-rwb
Copy link

@rnigro-rwb rnigro-rwb commented Nov 8, 2023 •
edited
Loading

Fixes #3318.

getJpegInfo now skips the DHT marker (0xc4) because that marker is not a SOF (start of frame) marker and therefore the segment to follow does not have the size information.

@rnigro-rwb rnigro-rwb mentioned this pull request Nov 8, 2023
Open
@HoekWax
Copy link

HoekWax commented Nov 15, 2023 •
edited
Loading

Hello @HackbrettXXX, is it possible to check and merge this fix ? We are multiple people facing this issue.

I can provide an image that creates the issue when used using addImage if you want me to.

Thanks.

@rnigro-rwb
Copy link
Author

Linking PR to issue.

Fixes #3318

@HoekWax
Copy link

HoekWax commented Nov 27, 2023

Hello @MrRio, can you or someone else review and merge this request ? Thanks

@ZanonLuc ZanonLuc mentioned this pull request Feb 28, 2024
Open
@racosa
Copy link
Contributor

racosa commented May 20, 2024

We also had this issue and this PR fixes it. Can someone merge this, please?

@rnigro-rwb rnigro-rwb force-pushed the 3318-jpeg-size-determination branch from 312ae22 to 0d4bddd Compare September 17, 2024 13:51
@rnigro-rwb
Copy link
Author

rnigro-rwb commented Sep 17, 2024 •
edited
Loading

@MrRio, @HackbrettXXX

To add to insight to this fix, the original getJpegInfo sites http://www.64lines.com/jpeg-width-height which itself sites a reference for header info: JPEG Header Information

As you can see here, Define Huffman table marker (FFC4), 0xC4 is a marker for the Huffman table.

My fix skips 0xC4 and adjusts the remaining Start of frame (SOFn) markers to be correct.

@github-actions github-actions bot added the Stale label Dec 25, 2024
@github-actions github-actions bot closed this Jan 1, 2025
@rnigro-rwb
Copy link
Author

@MrRio, @HackbrettXXX

Can this be re-opened? This fix is useful. Is there something that is missing from the PR to prevent it from being approved and merged?

rnigro-rwb
rnigro-rwb commented Jan 1, 2025
View reviewed changes
Copy link
Author

@rnigro-rwb rnigro-rwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsPDF images are corrupted when using large, smartphone-captured jpegs
4 participants
@rnigro-rwb @HoekWax @racosa @MrRio